Skip to content

ci: migrate from Jenkins to GitHub Actions#537

Merged
dennisklein merged 1 commit intoFairRootGroup:devfrom
dennisklein:ci
Nov 28, 2025
Merged

ci: migrate from Jenkins to GitHub Actions#537
dennisklein merged 1 commit intoFairRootGroup:devfrom
dennisklein:ci

Conversation

@dennisklein
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 27, 2025

📝 Walkthrough

Walkthrough

Removes CI and test infrastructure: FairMQTest.cmake, Jenkinsfile, two Containerfiles (test/ci/Containerfile.fedora, test/ci/Containerfile.ubuntu), and the Slurm helper test/ci/slurm-submit.sh, deleting CTest orchestration, Jenkins pipeline, container definitions, and Slurm submission logic.

Changes

Cohort / File(s) Change Summary
CI/CD Pipeline Infrastructure
Jenkinsfile
Deleted Jenkins pipeline definition (job matrix, per-node execution, orchestration, notifications, Slurm/container execution paths).
Testing Configuration
FairMQTest.cmake
Deleted CTest-based continuous testing setup (env and directory setup, CPU/env derivation, ctest_start/configure/build/test/submit orchestration, parallelism and failure handling).
Container Build Definitions
test/ci/Containerfile.fedora, test/ci/Containerfile.ubuntu
Deleted Fedora and Ubuntu Containerfiles that provisioned development images, installed build/test dependencies, and included optional image publish steps.
Slurm Integration
test/ci/slurm-submit.sh
Deleted Slurm submission helper script (defaults, CPUS calculation, srun invocation, logging, and exit-code propagation).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

  • Inspect repository CI configuration, README, and developer docs for references to the removed files.
  • Check other automation scripts or external pipelines that invoked slurm-submit.sh, FairMQTest.cmake, or the Containerfiles.
  • Verify whether an alternative CI/test workflow was added elsewhere or if migration guidance is needed.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a description explaining the migration from Jenkins to GitHub Actions, including rationale and any breaking changes or migration steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly describes the main change: migrating CI from Jenkins to GitHub Actions, which is supported by the deletion of Jenkins-related files (Jenkinsfile, FairMQTest.cmake) and other CI infrastructure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d37d9e and 5737098.

⛔ Files ignored due to path filters (4)
  • .github/actions/setup-deps/action.yml is excluded by !**/*.yml
  • .github/workflows/buildcache.yml is excluded by !**/*.yml
  • .github/workflows/ci.yml is excluded by !**/*.yml
  • test/ci/spack.yaml is excluded by !**/*.yaml
📒 Files selected for processing (5)
  • FairMQTest.cmake (0 hunks)
  • Jenkinsfile (0 hunks)
  • test/ci/Containerfile.fedora (0 hunks)
  • test/ci/Containerfile.ubuntu (0 hunks)
  • test/ci/slurm-submit.sh (0 hunks)
💤 Files with no reviewable changes (5)
  • test/ci/Containerfile.ubuntu
  • Jenkinsfile
  • FairMQTest.cmake
  • test/ci/slurm-submit.sh
  • test/ci/Containerfile.fedora

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dennisklein dennisklein force-pushed the ci branch 7 times, most recently from 25c3630 to 9d37d9e Compare November 28, 2025 15:36
@dennisklein dennisklein merged commit 7a8ccb8 into FairRootGroup:dev Nov 28, 2025
1 of 8 checks passed
@dennisklein dennisklein deleted the ci branch November 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant